[
https://issues.apache.org/jira/browse/LUCENE-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luca Cavanna updated LUCENE-3586:
---------------------------------
Attachment: LUCENE-3586.patch
Here is the first version of my patch, please let me know your comments.
I tried to do something more generic for command line tools and less "static"
but I found myself reinventing the wheel, writing stuff similar to commons cli,
so I gave up.
I basically added a new option called -dir-impl to CheckIndex, IndexReader and
IndexUpgrader (please let me know if I forgot some other tools). The new option
can have the following values (case insensitive): mmap, nio or simple. Any
other value is ignored and considered as default (FSDirectory.open).
I noticed a finally block used to close the directory inside IndexReader, but
it's missing on the other two classes, wouldn't it be better to add it to
CheckIndex and IndexUpgrader?
> Choose a specific Directory implementation running the CheckIndex main
> ----------------------------------------------------------------------
>
> Key: LUCENE-3586
> URL: https://issues.apache.org/jira/browse/LUCENE-3586
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Luca Cavanna
> Assignee: Luca Cavanna
> Priority: Minor
> Attachments: LUCENE-3586.patch
>
>
> It should be possible to choose a specific Directory implementation to use
> during the CheckIndex process when we run it from its main.
> What about an additional main parameter?
> In fact, I'm experiencing some problems with MMapDirectory working with a big
> segment, and after some failed attempts playing with maxChunkSize, I decided
> to switch to another FSDirectory implementation but I needed to do that on my
> own main.
> Should we also consider to use a FileSwitchDirectory?
> I'm willing to contribute, could you please let me know your thoughts about
> it?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
