[ 
https://issues.apache.org/jira/browse/LUCENE-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158296#comment-13158296
 ] 

Simon Willnauer commented on LUCENE-3586:
-----------------------------------------

hey luca, you patch looks good. I wonder if we should maybe add an enum to 
FSDirectory like 
{code}
enum Type {
  NIOFS,
  MMAP,
  SIMPLE;

}

{code}


and add FSDirectory#open(File, Type). Just an idea, this would make the 
CommandlineUtils obsolete and I think it could be useful... not sure what 
others think... uwe? 

bq. Forgot to mention that the patch applies to the 3x branch

usually we (I) only provide a patch against trunk since we do a merge when we 
backport so a patch doesn't help very often. So it'd be better if you'd use 
trunk to create patches.

simon
                
> Choose a specific Directory implementation running the CheckIndex main
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-3586
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3586
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Luca Cavanna
>            Assignee: Luca Cavanna
>            Priority: Minor
>         Attachments: LUCENE-3586.patch
>
>
> It should be possible to choose a specific Directory implementation to use 
> during the CheckIndex process when we run it from its main.
> What about an additional main parameter?
> In fact, I'm experiencing some problems with MMapDirectory working with a big 
> segment, and after some failed attempts playing with maxChunkSize, I decided 
> to switch to another FSDirectory implementation but I needed to do that on my 
> own main.
> Should we also consider to use a FileSwitchDirectory?
> I'm willing to contribute, could you please let me know your thoughts about 
> it?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to