[ 
https://issues.apache.org/jira/browse/LUCENE-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159894#comment-13159894
 ] 

Luca Cavanna commented on LUCENE-3586:
--------------------------------------

{quote}
Hmm, I don't think we should add an enum to FSDir here? Can we simply accept 
the class name and then just load that class (maybe prefixing oal.store so user 
doesn't have to type that all the time)?

Also, can we make it a hard error if the specified name isn't recognized? 
(Instead of silently falling back to FSDir.open).
{quote}

That's fine as well. Just a little bit longer than writing NIOFS, MMAP or 
SIMPLE, but I guess it doesn't matter. Mike, do you mean to load the class 
using reflection or compare the input string to those three class names?

Any other opinion?
                
> Choose a specific Directory implementation running the CheckIndex main
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-3586
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3586
>             Project: Lucene - Java
>          Issue Type: Improvement
>            Reporter: Luca Cavanna
>            Assignee: Luca Cavanna
>            Priority: Minor
>         Attachments: LUCENE-3586.patch
>
>
> It should be possible to choose a specific Directory implementation to use 
> during the CheckIndex process when we run it from its main.
> What about an additional main parameter?
> In fact, I'm experiencing some problems with MMapDirectory working with a big 
> segment, and after some failed attempts playing with maxChunkSize, I decided 
> to switch to another FSDirectory implementation but I needed to do that on my 
> own main.
> Should we also consider to use a FileSwitchDirectory?
> I'm willing to contribute, could you please let me know your thoughts about 
> it?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to