[ 
https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166312#comment-13166312
 ] 

Robert Muir commented on LUCENE-3622:
-------------------------------------

For now in the branch 
(https://svn.apache.org/repos/asf/lucene/dev/branches/lucene3622), i 
renamed/shuffled in r1212506.

You can take a look and see what you think... we can/should always be thinking 
of naming and how it can be simpler.

With separating out the abstract api, its small enough I moved it out of 
.values to just org.apache.lucene.index 
(which makes IndexDocValues seem awefully redundant).

Additionally PerDocValues was moved out of the codecs package, as you get it 
from IndexReader and it doesnt make 
sense under .codecs.

Finally ValueType is DocValues.Type (just like DocValues.Source, etc), and 
TypePromoter is now pkg-private, as its
just an implementation detail of SegmentMerger.
                
> separate IndexDocValues interface from implementation
> -----------------------------------------------------
>
>                 Key: LUCENE-3622
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3622
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-3622.patch
>
>
> Currently the o.a.l.index.values contains both the abstract apis and 
> Lucene40's current implementation.
> I think we should move the implementation underneath Lucene40Codec, leaving 
> only the abstract apis.
> For example, simpletext might have a different implementation, and we might 
> make a int8 implementation
> underneath preflexcodec to support norms.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to