[ 
https://issues.apache.org/jira/browse/LUCENE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221243#comment-13221243
 ] 

Robert Muir commented on LUCENE-3807:
-------------------------------------

Well I switched to a single file already, so ignore that implementation :)

But my concern is mostly about API confusion for implementing suggesters: if we 
require a single file then lets just have InputStream.
Otherwise, lets remove InputStream from Lookup, (of course a specific concrete 
Impl that only uses one file is still free to provide that)
                
> Cleanup suggester API
> ---------------------
>
>                 Key: LUCENE-3807
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3807
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: modules/other
>    Affects Versions: 3.6, 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.0
>
>         Attachments: LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch, 
> LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch
>
>
> Currently the suggester api and especially TermFreqIterator don't play that 
> nice with BytesRef and other paradigms we use in lucene, further the java 
> iterator pattern isn't that useful when it gets to work with TermsEnum, 
> BytesRef etc. We should try to clean up this api step by step moving over to 
> BytesRef including the Lookup class and its interface...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to