[
https://issues.apache.org/jira/browse/LUCENE-3807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-3807:
------------------------------------
Attachment: LUCENE-3807.patch
here is a patch that removes the file based store / load methods. Once thing I
don't like about this is that we use one an the same file name in solr to store
stuff. We could possibly fix this and make it bw compatible by pulling a file
name from the factory for instance but even that is kind of flaky. Maybe
somebody has a better idea.
Yet I think one of the biggest issues here is that we don't really have a
header on the actual implementation. Ie you could simply load a FST from a FST
suggester into WFST but the results would be bogus. I think we should add real
headers to the files to fail early and give good error messages.
> Cleanup suggester API
> ---------------------
>
> Key: LUCENE-3807
> URL: https://issues.apache.org/jira/browse/LUCENE-3807
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/other
> Affects Versions: 3.6, 4.0
> Reporter: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch,
> LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch, LUCENE-3807.patch,
> LUCENE-3807.patch
>
>
> Currently the suggester api and especially TermFreqIterator don't play that
> nice with BytesRef and other paradigms we use in lucene, further the java
> iterator pattern isn't that useful when it gets to work with TermsEnum,
> BytesRef etc. We should try to clean up this api step by step moving over to
> BytesRef including the Lookup class and its interface...
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
