[
https://issues.apache.org/jira/browse/LUCENE-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397324#comment-13397324
]
Shai Erera commented on LUCENE-4156:
------------------------------------
I've been thinking about it when I fixed it ... eventually I chose this way
because if we'll ever need to change getSize to call writer.maxDoc() again, or
implement otherwise for correctness, getParent will benefit from it too. I
don't know if it's critical though that there's a method call - is that what
bothers you?
> Improve implementation of DirectoryTaxonomyWriter.getSize()
> -----------------------------------------------------------
>
> Key: LUCENE-4156
> URL: https://issues.apache.org/jira/browse/LUCENE-4156
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Sivan Yogev
> Assignee: Shai Erera
> Priority: Minor
> Attachments: LUCENE-4156.patch
>
>
> Current implementation of DirectoryTaxonomyWriter.getSize() is synchrionized
> and invokes indexWriter.maxDoc(), both harming performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
