[
https://issues.apache.org/jira/browse/LUCENE-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397399#comment-13397399
]
Shai Erera commented on LUCENE-4156:
------------------------------------
You're right, 2 extra method calls are not worth the defensive code. If we'll
change getSize(), I hope that we'll remember to fix getParent too. At any rate,
the reason we check the size is for throwing a friendlier exception with text.
If someone passes an invalid ordinal, he'll get AIOOBE anyway, just without the
text.
I'll commit this now.
> Improve implementation of DirectoryTaxonomyWriter.getSize()
> -----------------------------------------------------------
>
> Key: LUCENE-4156
> URL: https://issues.apache.org/jira/browse/LUCENE-4156
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Sivan Yogev
> Assignee: Shai Erera
> Priority: Minor
> Attachments: LUCENE-4156.patch
>
>
> Current implementation of DirectoryTaxonomyWriter.getSize() is synchrionized
> and invokes indexWriter.maxDoc(), both harming performance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
