[ https://issues.apache.org/jira/browse/LUCENE-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397356#comment-13397356 ]
Sivan Yogev commented on LUCENE-4156: ------------------------------------- Since getParent() could be heavily used during facets indexing I was thinking that reducing the two method calls (one to getParent another for ensureOpen) could make a difference, but you are right that it is not safe for future implementation details. So best keep the patch as is. > Improve implementation of DirectoryTaxonomyWriter.getSize() > ----------------------------------------------------------- > > Key: LUCENE-4156 > URL: https://issues.apache.org/jira/browse/LUCENE-4156 > Project: Lucene - Java > Issue Type: Improvement > Components: modules/facet > Reporter: Sivan Yogev > Assignee: Shai Erera > Priority: Minor > Attachments: LUCENE-4156.patch > > > Current implementation of DirectoryTaxonomyWriter.getSize() is synchrionized > and invokes indexWriter.maxDoc(), both harming performance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org