[ 
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535829#comment-13535829
 ] 

Shahar Davidson commented on SOLR-2894:
---------------------------------------

Hi Chris,

#1 Yes, I believe the patch applied correctly. Once more, *default* sorting 
method is not defined and I didn't see where DistributedFacetPivotTest is 
testing the default sort. (I did however see where facet.sort is tested after 
facet.sort=count was explicitly specified).
#2 Yes, Per field sorting works with non-distributed pivots. We were working in 
a non-distributed configuration up to some point and, until then, per field 
sorting worked properly (that was on Solr 4.0)

We also encountered another issue when sorting by count:
There might be a case where 2 of the returned values have the same count. In 
such a case, the PivotNamedListCountComparator attempts to sort by value. The 
problem is that when facet.missing=true is specified then one of the 2 values 
which have the same count may be null (missing) and in such cases the 
get("value").toString() operation will fail (NullPointerException).
                
> Implement distributed pivot faceting
> ------------------------------------
>
>                 Key: SOLR-2894
>                 URL: https://issues.apache.org/jira/browse/SOLR-2894
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Erik Hatcher
>             Fix For: 4.1
>
>         Attachments: SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894-reworked.patch
>
>
> Following up on SOLR-792, pivot faceting currently only supports 
> undistributed mode.  Distributed pivot faceting needs to be implemented.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to