[
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539395#comment-13539395
]
Shahar Davidson commented on SOLR-2894:
---------------------------------------
Hi Chris,
I appreciate your efforts on this.
I tried the new patch and run into numerous NPEs and didn't get to verify the
sorting.
Here's what I'm getting:
{noformat}
SEVERE: null:java.lang.NullPointerException
at java.util.TreeMap.compare(TreeMap.java:1188)
at java.util.TreeMap.put(TreeMap.java:531)
at
org.apache.solr.handler.component.PivotFacetHelper.convertPivotsToMaps(PivotFacetHelper.java:317)
at
org.apache.solr.handler.component.FacetComponent.countFacets(FacetComponent.java:542)
at
org.apache.solr.handler.component.FacetComponent.handleResponses(FacetComponent.java:336)
at
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:309)
at
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:144)
at org.apache.solr.core.SolrCore.execute(SolrCore.java:1830)
at
org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:455)
at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:276)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1337)
....
{noformat}
And also:
{noformat}
SEVERE: null:java.lang.NullPointerException
at java.util.TreeMap.getEntry(TreeMap.java:342)
at java.util.TreeMap.get(TreeMap.java:273)
at
org.apache.solr.handler.component.FacetComponent.mergePivotFacet(FacetComponent.java:692)
at
org.apache.solr.handler.component.FacetComponent.countFacets(FacetComponent.java:552)
at
org.apache.solr.handler.component.FacetComponent.handleResponses(FacetComponent.java:336)
at
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:309)
at
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:144)
at org.apache.solr.core.SolrCore.execute(SolrCore.java:1830)
at
org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:455)
at
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:276)
at
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1337)
....
{noformat}
Since I couldn't get to test the sorting fix, I peaked at the
PivotNamedListCountComparator fix and I believe it will sort the "null" values
on top (due to the return values of handleSortWhenOneValueIsNull) and
regardless of the count number (due to the fact that the null values are
checked before comparing the counts) - correct me if I'm wrong.
Appreciate your help with this,
Shahar.
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Fix For: 4.1
>
> Attachments: SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894-reworked.patch
>
>
> Following up on SOLR-792, pivot faceting currently only supports
> undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
