[ 
https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13611757#comment-13611757
 ] 

Yonik Seeley commented on SOLR-4586:
------------------------------------

bq. I disagree with Integer.MAX_VALUE (as i said on LUCENE-4835)

The argument there seemed to be more about Lucene (a programmer bug that kept 
adding clauses), although this is an extremely weird way to help catch such an 
error.
Put another way... if the static max clauses had never existed, would it be 
added today?  I don't think so.  It was added in the past for historical 
reasons (auto-expanding queries) that hopefully no longer apply today.

Anyway, for Solr-land, if we want to enforce on a per-core basis then we can do 
that at the Solr query parser level.  I see no reason to do that though.  I 
think we should just remove the limit altogether at the solr level.
                
> Increase default maxBooleanClauses
> ----------------------------------
>
>                 Key: SOLR-4586
>                 URL: https://issues.apache.org/jira/browse/SOLR-4586
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.2
>         Environment: 4.3-SNAPSHOT 1456767M - ncindex - 2013-03-15 13:11:50
>            Reporter: Shawn Heisey
>         Attachments: SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, 
> SOLR-4586.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to 
> someone asking a question about queries.  Mark Miller told me that 
> maxBooleanClauses no longer applies, that the limitation was removed from 
> Lucene sometime in the 3.x series.  The config still shows up in the example 
> even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed 
> and the value stored in objects, but does not actually seem to be used by 
> anything.  I removed every trace of it that I could find, and all tests still 
> pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to