[ 
https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614407#comment-13614407
 ] 

Shawn Heisey commented on SOLR-4586:
------------------------------------

Here's my proposal:

The current 4x patch goes in largely as it is now.  Changes:
1) Remove the solr.xml additions.
2) Log a deprecation warning when maxBooleanClauses is found in solrconfig.xml, 
but honor it.
2a) Should we make it possible to go lower than Lucene's default?  The current 
patch won't.
3) Make some tests to verify behavior.  I'm willing to do this, but I will need 
a little guidance.

With the current POST buffer default size of 2MiB, you could include just under 
2^20 boolean clauses, if each clause were only 1 byte, a highly contrived and 
illogical query.  For that reason, I think that 2^20 is a reasonable default 
value.  Also, I think that performance would become intolerable long before you 
reached that many clauses, and I think that will continue to be the case for 
the foreseeable future.

For 5.0, we remove the maxBooleanClauses config entirely.  If someone really 
did have a viable use case for more than 2^20 clauses, they would very likely 
have the expertise required to modify Solr code.

Would it be a good idea to file another issue to have Solr use a better 
solution than BooleanQuery when possible?

                
> Increase default maxBooleanClauses
> ----------------------------------
>
>                 Key: SOLR-4586
>                 URL: https://issues.apache.org/jira/browse/SOLR-4586
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.2
>         Environment: 4.3-SNAPSHOT 1456767M - ncindex - 2013-03-15 13:11:50
>            Reporter: Shawn Heisey
>         Attachments: SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, 
> SOLR-4586.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to 
> someone asking a question about queries.  Mark Miller told me that 
> maxBooleanClauses no longer applies, that the limitation was removed from 
> Lucene sometime in the 3.x series.  The config still shows up in the example 
> even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed 
> and the value stored in objects, but does not actually seem to be used by 
> anything.  I removed every trace of it that I could find, and all tests still 
> pass.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to