[
https://issues.apache.org/jira/browse/LUCENE-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613707#comment-13613707
]
Michael McCandless commented on LUCENE-4883:
--------------------------------------------
+1, I think this (moving FieldCache under UnInvertingFilterReader) is a great
idea, and the patch looks like a great start! But I assume the plan is to
remove oal.search.FieldCache entirely right (after everything is cutover)?
bq. which package should this stuff be in? FieldCache is in o.a.l.search, and
the reader is in o.a.l.index.
I think aol.index is the right place.
bq. there are a bunch of FieldCache-specific queries and filters. Can these
just be reworked to be DV-specific instead?
I think they should all cutover to DV? Maybe we should make a branch for this
... seems biggish :)
bq. can we consolidate the various Ints, Floats, Shorts etc FieldCache
interfaces into NumericDocValues?
I think so ... this would happen "for free" once we cutover direct FieldCache
consumers to DocValues.
bq. this still uses the global FieldCache. Should the caches be moved to the
readers instead?
I think so.
> Hide FieldCache behind an UninvertingFilterReader
> -------------------------------------------------
>
> Key: LUCENE-4883
> URL: https://issues.apache.org/jira/browse/LUCENE-4883
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-4883.patch
>
>
> From a discussion on the mailing list:
> {{
> rmuir:
> I think instead FieldCache should actually be completely package
> private and hidden behind a UninvertingFilterReader and accessible via
> the existing AtomicReader docValues methods.
> }}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
