[ 
https://issues.apache.org/jira/browse/LUCENE-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613729#comment-13613729
 ] 

Alan Woodward commented on LUCENE-4883:
---------------------------------------

bq. But I assume the plan is to remove aol.search.FieldCache entirely

I wasn't going to initially - just make it package private.  But thinking about 
it, can we just put a map of fieldnames->XXXDocValues in a threadlocal on 
UninvertingFilterReader (like on SegmentCoreReaders)?  That makes things a lot 
cleaner.  We'd need a way to purge the map, though.

bq. Maybe we should make a branch for this

Having just spent an hour or so trying to cut things over, yes, that's probably 
a good idea :-)  It touches a lot of the codebase.  Should simplify things like 
SortField a lot though.
                
> Hide FieldCache behind an UninvertingFilterReader
> -------------------------------------------------
>
>                 Key: LUCENE-4883
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4883
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-4883.patch
>
>
> From a discussion on the mailing list:
> {{
> rmuir:
> I think instead FieldCache should actually be completely package
> private and hidden behind a UninvertingFilterReader and accessible via
> the existing AtomicReader docValues methods.
> }}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to