[ https://issues.apache.org/jira/browse/LUCENE-4883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614316#comment-13614316 ]
Alan Woodward commented on LUCENE-4883: --------------------------------------- bq. I think it needs to take this information up-front: a mapping of field names from the underlying fieldinfos to docvalues types I was wondering about how to do this. We could add an optional Map<String, DocValuesType> parameter to the UFR constructor - if it's absent, then you can uninvert any field you like, at the risk of fieldcache-insanity. Otherwise you're restricted to just the fields in the map, but you know you're not going to uninvert the wrong type. Applications like Solr or ES can manage the types outside of UFR using their own field type information. bq. How can we expose "missing" for NumericDocValues I was going to move the FieldCache#getDocsWithField() method to AtomicReader, but I see that this doesn't actually work in the same way with DocValues at the moment. Maybe for the moment we should just get FieldCache moved into UFR and worry about passing CheckIndex in another issue? Unless you think that we'll end up having to make major changes if we don't build this in from the beginning. I'm new to a lot of this part of the codebase, so all advice is very welcome here :-) > Hide FieldCache behind an UninvertingFilterReader > ------------------------------------------------- > > Key: LUCENE-4883 > URL: https://issues.apache.org/jira/browse/LUCENE-4883 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Alan Woodward > Assignee: Alan Woodward > Priority: Minor > Attachments: LUCENE-4883.patch > > > From a discussion on the mailing list: > {{ > rmuir: > I think instead FieldCache should actually be completely package > private and hidden behind a UninvertingFilterReader and accessible via > the existing AtomicReader docValues methods. > }} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org