[ 
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13757921#comment-13757921
 ] 

Shai Erera commented on LUCENE-5189:
------------------------------------

bq. It does not solve problem #2 (SegmentInfos.attributes)

Correct. So this API is broken today for LiveDocsFormat (since it's the only 
updateable thing), but field updates only broaden the broken-ness into other 
formats (now only DVF, but in the future others too). Correct?

I think that moving this API into the commit is not an overkill. I remember 
Mike and I once discussed if we can use that API to save per-segment facets 
"schema details". I don't remember how this ended, but maybe we shouldn't 
remove it? Alternatively, we could gen SIFormat too ... that may be an overkill 
though. Recording per-segment StringStringMap in SIS seems simple enough.

Regarding FIS.gen, I honestly thought to keep it simple by writing all FIS 
entirely in each gen and not complicate the code by writing parts of an FI in 
different gens and merging them by SR. This is what I plan to do in this issue.
                
> Numeric DocValues Updates
> -------------------------
>
>                 Key: LUCENE-5189
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5189
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: core/index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch, 
> LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch
>
>
> In LUCENE-4258 we started to work on incremental field updates, however the 
> amount of changes are immense and hard to follow/consume. The reason is that 
> we targeted postings, stored fields, DV etc., all from the get go.
> I'd like to start afresh here, with numeric-dv-field updates only. There are 
> a couple of reasons to that:
> * NumericDV fields should be easier to update, if e.g. we write all the 
> values of all the documents in a segment for the updated field (similar to 
> how livedocs work, and previously norms).
> * It's a fairly contained issue, attempting to handle just one data type to 
> update, yet requires many changes to core code which will also be useful for 
> updating other data types.
> * It has value in and on itself, and we don't need to allow updating all the 
> data types in Lucene at once ... we can do that gradually.
> I have some working patch already which I'll upload next, explaining the 
> changes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to