[
https://issues.apache.org/jira/browse/LUCENE-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758233#comment-13758233
]
Michael McCandless commented on LUCENE-5189:
--------------------------------------------
bq. Frankly I am tired of hearing this phrase being used in this way
Actually, I think this is a fair use of "progress not perfection".
Either that or I don't understand what you're calling "broken APIs" in
the current patch.
As I understand it, what's "broken" here is that you cannot set the
attributes in SegmentInfo nor FieldInfo from your DocValuesFormat
writer when it's an update being written: the changes won't be saved.
So, I proposed that we document this as a limitation of the SI/FI
attributes API: when writing updates, any changes will be lost. For
"normal" segment flushes, they work correctly. It'd be a documented
limitation, and we can later fix it.
I think this situation is very similar to LUCENE-5197, which I would
also call "progress not perfection": we are adding a new API
(SegmentReader.ramBytesUsed), with an initial implementation that we
think might be improved by later cutting over to RamUsageEstimator.
But I think we should commit the initial approach (it's useful, it
should work well) and later improve the implementation.
> Numeric DocValues Updates
> -------------------------
>
> Key: LUCENE-5189
> URL: https://issues.apache.org/jira/browse/LUCENE-5189
> Project: Lucene - Core
> Issue Type: New Feature
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch,
> LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch, LUCENE-5189.patch
>
>
> In LUCENE-4258 we started to work on incremental field updates, however the
> amount of changes are immense and hard to follow/consume. The reason is that
> we targeted postings, stored fields, DV etc., all from the get go.
> I'd like to start afresh here, with numeric-dv-field updates only. There are
> a couple of reasons to that:
> * NumericDV fields should be easier to update, if e.g. we write all the
> values of all the documents in a segment for the updated field (similar to
> how livedocs work, and previously norms).
> * It's a fairly contained issue, attempting to handle just one data type to
> update, yet requires many changes to core code which will also be useful for
> updating other data types.
> * It has value in and on itself, and we don't need to allow updating all the
> data types in Lucene at once ... we can do that gradually.
> I have some working patch already which I'll upload next, explaining the
> changes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
