NightOwl888 commented on code in PR #690:
URL: https://github.com/apache/lucenenet/pull/690#discussion_r996884799
##########
src/Lucene.Net/Index/FreqProxTermsWriterPerField.cs:
##########
@@ -387,7 +387,7 @@ internal override int BytesPerPosting()
}
[MethodImpl(MethodImplOptions.NoInlining)]
- public void Abort()
+ public static void Abort()
Review Comment:
I took a look and this method is not being called, so it is dead code. I ran
the tests to confirm it has no purpose. So, the appropriate thing to do would
be to remove it and replace it with a comment.
```
// LUCENENET: Removed Abort() method because it is not in use.
```
##########
src/Lucene.Net/Index/TermVectorsConsumerPerField.cs:
##########
@@ -141,7 +141,7 @@ internal override bool Start(IIndexableField[] fields, int
count)
}
[MethodImpl(MethodImplOptions.NoInlining)]
- public void Abort()
+ public static void Abort() // LUCENENET: CA1822: Mark members as static
Review Comment:
I took a look and this method is not being called, so it is dead code. I ran
the tests to confirm it has no purpose. So, the appropriate thing to do would
be to remove it and replace it with a comment.
```
// LUCENENET: Removed Abort() method because it is not in use.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
