NightOwl888 commented on PR #690:
URL: https://github.com/apache/lucenenet/pull/690#issuecomment-1280675940
Actually, have you kept track of the methods we decided not to mark static
that are triggering this warning? If so, we should suppress those via attribute.
```c#
[SuppressMessage("Performance", "CA1822:Mark members as static",
Justification = "By design")]
```
If you haven't kept track:
1. We can merge this to master and then scan, and then submit a new PR with
these attributes.
2. Scan this branch to find the CA1822 warnings and fix them before the
merge.
3. Use Visual Studio to scan the entire solution for CA1822, and submit
another commit to this PR with these attributes.
4. Use the conversations above to try to work it out, but I think we may
miss some that way. Most likely we would need another PR to add attributes
where they are missing.
Any option is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
