NightOwl888 commented on PR #690: URL: https://github.com/apache/lucenenet/pull/690#issuecomment-1280720674
> We should be able to find all the cases where we have decided that we cannot mark methods static in this commit: [bbf4289](https://github.com/apache/lucenenet/commit/bbf4289e7a689fddec14a7575702f2335e6d94a7) Yea, that looks like it could work for what we have in this PR. You can go ahead and move the attribute up to the class level for the one test class instead of putting it on every test method (although, not sure why we are getting a test class, since the CA1822 warning suppression is explicitly configured in all of the test projects). But, you are right about the cascade effect of warnings that happen due to fixing these. We had already fixed these once, and are finding them again. So it may take a few iterations to catch them all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
