laimis opened a new pull request, #801: URL: https://github.com/apache/lucenenet/pull/801
Continuation of fixes with virtual calls being made from constructors. The issue originally reported by SonarCloud scans: https://sonarcloud.io/project/issues?resolved=false&rules=csharpsquid%3AS1699&id=apache_lucenenet and referenced in this issue: https://github.com/apache/lucenenet/issues/670 This time I focused on cases where a class is public, we are breaking the API, BUT, the method that was marked virtual was not calling any other virtual methods, was not being overridden in Lucene repo, and/or looked like a method that was not meant to be overridden to change the behavior of the class. Similarly to #798 , preferring explicit/clear/no surprises break in API over introducing locking/lazy initialization/additional allocations when the public consumers have a way to safely extend the class behavior. This should eliminate the majority of "easy" changes, leaving us with a few "hairer" cases that we will tackle separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
