laimis commented on code in PR #801:
URL: https://github.com/apache/lucenenet/pull/801#discussion_r1160936619
##########
src/Lucene.Net.Facet/Taxonomy/Directory/DirectoryTaxonomyReader.cs:
##########
@@ -241,15 +241,19 @@ protected override TaxonomyReader DoOpenIfChanged()
/// <summary>
/// Open the <see cref="DirectoryReader"/> from this <see
cref="Directory"/>.
/// </summary>
- protected virtual DirectoryReader OpenIndexReader(Directory directory)
+ // LUCENENET specific - S1699 - marked non-virtual because calling
+ // virtual members from the constructor is not a safe operation in .NET
+ protected DirectoryReader OpenIndexReader(Directory directory)
Review Comment:
OK, I will leave this one alone here and will revisit it separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
