laimis commented on code in PR #801:
URL: https://github.com/apache/lucenenet/pull/801#discussion_r1160935272
##########
src/Lucene.Net.Suggest/Spell/SpellChecker.cs:
##########
@@ -142,8 +142,9 @@ public SpellChecker(Directory spellIndex, IStringDistance
sd, IComparer<SuggestW
/// <param name="spellIndexDir"> the spell directory to use </param>
/// <exception cref="ObjectDisposedException"> if the Spellchecker is
already closed </exception>
/// <exception cref="IOException"> if spellchecker can not open the
directory </exception>
- // TODO: we should make this final as it is called in the constructor
- public virtual void SetSpellIndex(Directory spellIndexDir)
+ // LUCENENET specific - S1699 - marked non-virtual because calling
+ // virtual members from the constructor is not a safe operation in .NET
+ public void SetSpellIndex(Directory spellIndexDir)
Review Comment:
Awesome, made the fix here: https://github.com/apache/lucenenet/pull/804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
