paulirwin commented on code in PR #1: URL: https://github.com/apache/lucenenet-codeanalysis-dev/pull/1#discussion_r1990018994
########## src/Lucene.Net.CodeAnalysis.Dev.Sample/Lucene.Net.CodeAnalysis.Dev.Sample.csproj: ########## @@ -0,0 +1,14 @@ +<Project Sdk="Microsoft.NET.Sdk"> Review Comment: I'd prefer renaming the tests project if you're okay with that. It seems like "Lucene.Net.CodeAnalysis.Dev" naturally feels like the prefix of the projects, via the solution name. re: duplciated code, the Sample project is for a playground to experiment with the analyzers or debug them locally, not to assert i.e. in CI builds that they work correctly. I intentionally just copied the test examples into the Sample project just as a starting point; they might diverge in the future. re: Visual Studio needing a new version number, I don't believe this is true anymore. I was able to make a change in Visual Studio 2022 (and Rider, fwiw) and after building it was immediately reflected in the sample project. I think Microsoft might have fixed this in an updated Analyzer SDK. It'd be great if you could give it a try yourself to confirm. That doesn't invalidate the need for gitversioning, but just an FYI on that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
