NightOwl888 commented on PR #1: URL: https://github.com/apache/lucenenet-codeanalysis-dev/pull/1#issuecomment-2719822940
One thing I forgot about in the review was that since this project will be a private dependency of all of the Lucene.Net projects, it should be strong named to avoid the build warning. Ideally, we would use the same SNK from the lucenenet repo, but I see no issue with copying it here, since it is unlikely we will ever change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
