paulirwin commented on code in PR #1:
URL:
https://github.com/apache/lucenenet-codeanalysis-dev/pull/1#discussion_r1992700796
##########
src/Lucene.Net.CodeAnalysis.Dev/Lucene.Net.CodeAnalysis.Dev.csproj:
##########
@@ -3,16 +3,21 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IsPackable>false</IsPackable>
+ <Nullable>enable</Nullable>
+ <LangVersion>latest</LangVersion>
+ <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
+ <IsRoslynComponent>true</IsRoslynComponent>
+ <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
- <Version>1.0.2</Version>
-
- <!-- Avoid ID conflicts with the package project. -->
- <PackageId>*$(MSBuildProjectFile)*</PackageId>
+ <Version>1.0.0</Version>
Review Comment:
Split out adding Nerdbank.GitVersioning as separate issue
https://github.com/apache/lucenenet/issues/1142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
