NightOwl888 commented on code in PR #1: URL: https://github.com/apache/lucenenet-codeanalysis-dev/pull/1#discussion_r1992796684
########## src/Lucene.Net.CodeAnalysis.Dev/AnalyzerReleases.Unshipped.md: ########## @@ -0,0 +1,9 @@ +### New Rules Review Comment: The fact that there are currelty only 5 analyzers is a symptom that this hasn't been easy enough to manage in the past. - There are many project maintenance tasks that would ideally be made into Roslyn analyzers than what are currently open. For example, [TestApiConsistency](https://github.com/apache/lucenenet/blob/a96e768d14431cf9d85e394a333cd10c9112e975/src/Lucene.Net.TestFramework/Support/ApiScanTestBase.cs) (and all of its support attributes) can be made into code analyzers. - There were search analyzers that I ended up deleting because there was no logical way to categorize them so they wouldn't impede development. - There are several open issues regarding analyzers, some of which will probably end up with at least half a dozen different IDs. My point is, I can see this easily reaching 50 or more analyzers before the Lucene.Net release. We will also have analyzers in ICU4N and it would be ideal to use the same process to manage ID uniqueness. Since Microsoft has been doing this for a while, it seems like the best idea is to follow their lead rather than go off the map and try something that may or may not work for the long haul. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
