paulirwin commented on code in PR #1154:
URL: https://github.com/apache/lucenenet/pull/1154#discussion_r2286830636
##########
src/Lucene.Net.Analysis.SmartCn/Hhmm/AbstractDictionary.cs:
##########
@@ -33,7 +33,9 @@ namespace Lucene.Net.Analysis.Cn.Smart.Hhmm
internal abstract class AbstractDictionary
{
// LUCENENET specific: cached GB2312 encoding to avoid repeated calls
to Encoding.GetEncoding("GB2312")
- protected static readonly Encoding gb2312Encoding =
Encoding.GetEncoding("GB2312");
+ protected static readonly Encoding gb2312Encoding =
Encoding.GetEncoding("GB2312",
+ EncoderFallback.ExceptionFallback, DecoderFallback.ExceptionFallback);
Review Comment:
We intended this change. Closing as "won't fix."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
