Re: [PR] feat: Optimize SmartCn Dictionaries and Add Dictionary Loading Tests [lucenenet]

Fri, 17 Oct 2025 15:31:33 -0700 


NehanPathan commented on PR #1154:
URL: https://github.com/apache/lucenenet/pull/1154#issuecomment-3373122019

   > > @paulirwin @NightOwl888,
   > > I’ve tried adding final newlines and removing trailing whitespace in the 
most of files I could identify, but the check-editorconfig CI is still failing.
   > > Is there a recommended way to apply this fix across all files in the 
repo safely so the CI passes, without accidentally touching unrelated code? 
beacause same test fail in #1182 pr also
   > 
   > Which text editor are you using to modify the file? Most editors that are 
widely used for development either have native support for `.editorconfig` 
files or there is a plugin to download (and possibly enable in settings). Once 
it is enabled, the editor should respect the settings and add the newline 
automatically.
   > 
   > It also helps to have line numbers and whitespace enabled so they are 
visible in the editor window. Here is how I have Notepad++ configured:
   > 
   > <img alt="image" width="1038" height="514" 
src="https://private-user-images.githubusercontent.com/1538288/497930064-ee3cfab6-32e4-49e6-a60f-0bda91d4ac64.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTk3NzMxNjUsIm5iZiI6MTc1OTc3Mjg2NSwicGF0aCI6Ii8xNTM4Mjg4LzQ5NzkzMDA2NC1lZTNjZmFiNi0zMmU0LTQ5ZTYtYTYwZi0wYmRhOTFkNGFjNjQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MTAwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTEwMDZUMTc0NzQ1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MTg2YWVhYmQzYTBmNGE4YmE4Y2Y5OTdkYmU2YWQ2MWQyNjc0MmIwMThmNDFkMTkwODJlMDcwNzRlMjE1ZjRmNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Unbn_Na8VTbRmbJijTvUM9MNvbBv_U4mP-EobkkcENE";>
   > As you can see, the final newline is missing.
   > 
   > I would be happy to fix it for you, but I think it would be best if we 
figure out how to set up your editor so you can quickly work through these 
errors.
   
   @NightOwl888 
   as per Paul suggestion i have done my editor setup previously 
   but still don't know why this problem occur


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to