paulirwin commented on code in PR #1222: URL: https://github.com/apache/lucenenet/pull/1222#discussion_r2684220587
########## src/dotnet/Lucene.Net.Tests.CodeAnalysis/Lucene.Net.Tests.CodeAnalysis.csproj: ########## @@ -22,11 +22,13 @@ <Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> - <TargetFramework>net9.0</TargetFramework> + <!-- We don't really care which target framework we test with - this is just to emulate Visual Studio 2017+ all which can load netstandard1.3 analyzers --> + <!-- Given that VS 2022 doesn't support net10.0 we will use net8.0 (which will outlive net9.0). We will need to adjust this when we stop testing on net8.0. --> Review Comment: This comment is incorrect. .NET 8 and 9 will go out of support on the same day. The .NET STS support policy changed in September. https://devblogs.microsoft.com/dotnet/dotnet-sts-releases-supported-for-24-months/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
