[GitHub] madlib pull request #271: Madpack: Make install, reinstall and upgrade atomi...

[kaknikhil]

Github user kaknikhil commented on a diff in the pull request:

    https://github.com/apache/madlib/pull/271#discussion_r191607127
  
    --- Diff: src/madpack/madpack.py ---
    @@ -824,6 +873,246 @@ def parse_arguments():
         # Get the arguments
         return parser.parse_args()
     
    +def run_install_check(args, testcase):
    +    schema = args['schema']
    --- End diff --
    
    there is a decent chunk of code logic duplicated in this function and 
`_db_create_objects`. Can we reuse this code logic ?


---