Github user kaknikhil commented on a diff in the pull request: https://github.com/apache/madlib/pull/271#discussion_r191589562 --- Diff: src/madpack/madpack.py --- @@ -238,6 +311,88 @@ def _run_sql_file(schema, maddir_mod_py, module, sqlfile, return retval # ------------------------------------------------------------------------------ +def _run_sql_file(schema, sqlfile): --- End diff -- The three functions `_run_sql_file` , `_run_sql_file_install_check` and `_run_m4_and_append` have some code logic duplicated related to running m4 and running the sql file. Can we refactor this to not have any duplicated code ?
---