kaknikhil commented on a change in pull request #483: Graph/type bigint
URL: https://github.com/apache/madlib/pull/483#discussion_r386680964
##########
File path: src/ports/postgres/modules/graph/sssp.py_in
##########
@@ -411,6 +412,24 @@ def graph_sssp_get_path(schema_madlib, sssp_table,
dest_vertex, path_table,
summary = plpy.execute("SELECT * FROM {0}".format(summary_table))
vertex_id = summary[0]['vertex_id']
source_vertex = summary[0]['source_vertex']
+ edge_args = summary[0]['edge_args']
+
+ params_types = {'src': str, 'dest': str, 'weight': str}
+ default_args = {'src': 'src', 'dest': 'dest', 'weight': 'weight'}
+ edge_params = extract_keyvalue_params(edge_args,
+ params_types,
+ default_args)
+ src = edge_params["src"]
+ dest = edge_params["dest"]
+ weight = edge_params["weight"]
+
+ # Find the appropriate column type for correct concat operations
+ types = get_cols_and_types(sssp_table)
+ final_type = 'integer'
+ for i in types:
Review comment:
```suggestion
for name,type in names_and_types:
# We want to check the column types except the weight column
if type == 'bigint' and name != weight:
final_type = 'bigint'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
