kaknikhil commented on a change in pull request #483: Graph/type bigint
URL: https://github.com/apache/madlib/pull/483#discussion_r384680623
##########
File path: src/ports/postgres/modules/graph/wcc.py_in
##########
@@ -294,7 +294,7 @@ def wcc(schema_madlib, vertex_table, vertex_id,
edge_table, edge_args,
if not is_platform_pg():
# Drop intermediate table created for Greenplum
plpy.execute("DROP TABLE IF EXISTS {0}".format(edge_inverse))
- plpy.execute("ALTER TABLE {0} RENAME TO {1}".format(newupdate, out_table))
+ plpy.execute("CREATE TABLE {0} AS SELECT * FROM {1}".format(out_table,
newupdate))
Review comment:
don't we have to drop the `newupdate` table now that we are not renaming it
? Also why did we change this code from rename to CTAS?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
