kaknikhil commented on a change in pull request #483: Graph/type bigint
URL: https://github.com/apache/madlib/pull/483#discussion_r386577902
##########
File path: src/ports/postgres/modules/graph/hits.py_in
##########
@@ -374,10 +374,8 @@ def update_final_results(converged, threshold, cur,
temp_summary_table,
grouping_cols_list,
distinct_grp_table)
else:
- plpy.execute("""
- ALTER TABLE {table_name}
- RENAME TO {out_table}
- """.format(table_name=cur, **locals()))
+ plpy.execute("CREATE TABLE {0} AS SELECT * FROM {1}".format(out_table,
cur))
Review comment:
we should instead use the `rename_table` function from validate_args.py_in.
same for all the other changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
