[GitHub] [madlib] kaknikhil commented on a change in pull request #564: MLP: Add rmsprop and Adam optimization techniques

[GitBox]

kaknikhil commented on a change in pull request #564:
URL: https://github.com/apache/madlib/pull/564#discussion_r620765049



##########
File path: src/modules/convex/algo/igd.hpp
##########
@@ -157,6 +157,87 @@ IGD<State, ConstState, Task>::merge(state_type &state,
     return;
  }
 
+/**
+  * @brief Update the transition state in mini-batches

Review comment:
       We should update this comment




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org