[GitHub] [madlib] orhankislal commented on a change in pull request #564: MLP: Add rmsprop and Adam optimization techniques

[GitBox]

orhankislal commented on a change in pull request #564:
URL: https://github.com/apache/madlib/pull/564#discussion_r622948559



##########
File path: src/modules/convex/algo/igd.hpp
##########
@@ -36,6 +36,7 @@ class IGD {
     static void transition(state_type &state, const tuple_type &tuple);
     static void merge(state_type &state, const_state_type &otherState);
     static void transitionInMiniBatch(state_type &state, const tuple_type 
&tuple);
+    static void transitionInALR(state_type &state, const tuple_type &tuple);

Review comment:
       I dislike over-descriptive function/variable names. `transitionWithALR` 
would be more meaningful but if we want the `minibatch` in 
`transitionInMiniBatchWithALR` would work as well.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org