[GitHub] [madlib] orhankislal commented on a change in pull request #564: MLP: Add rmsprop and Adam optimization techniques

[GitBox]

orhankislal commented on a change in pull request #564:
URL: https://github.com/apache/madlib/pull/564#discussion_r622921475



##########
File path: src/modules/convex/type/state.hpp
##########
@@ -819,11 +819,13 @@ class MLPMiniBatchState {
      * - N + 4: is_classification (do classification)
      * - N + 5: activation (activation function)
      * - N + 6: coeff (coefficients, design doc: u)
+     * - N + 7: momentum

Review comment:
       These were already in the state, I just fixed the comment when I noticed 
the omission.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org