[
https://issues.apache.org/jira/browse/MAHOUT-881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149113#comment-13149113
]
Sean Owen commented on MAHOUT-881:
----------------------------------
Both good points, I get you now. For me, these last few are valid, and tally up
to enough of a theoretical win that I support the patch. I'm guessing that it's
still virtually identically fast in practice -- for example the expected number
of add/poll operations when finding the top 10 is just about 20 anyway. I know
from profiling that virtually no time is spent here. Even if it adds some code,
I think it's nice.
> Refactor TopItems to use Lucene's PriorityQueue and remove excessive sorting
> ----------------------------------------------------------------------------
>
> Key: MAHOUT-881
> URL: https://issues.apache.org/jira/browse/MAHOUT-881
> Project: Mahout
> Issue Type: Improvement
> Affects Versions: 0.6
> Reporter: Grant Ingersoll
> Assignee: Grant Ingersoll
> Priority: Minor
> Attachments: MAHOUT-881.patch
>
>
> TopItems.getTop*() all do a fair number of excessive operations that can be
> replaced by switching to using Lucene's PriorityQueue implementation, which
> is more efficient and faster than Java's built in PQ implementation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
