[ 
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112290#comment-14112290
 ] 

ASF GitHub Bot commented on MAHOUT-1610:
----------------------------------------

GitHub user srowen opened a pull request:

    https://github.com/apache/mahout/pull/46

    MAHOUT-1610 [TESTS] Update tests to pass in Java 8

    Right now, several tests don't seem to pass when run with Java 8 (at least 
on Java 8). The failures are benign, and just due to tests looking for 
too-specific values or expecting things like a certain ordering of hashmaps.
    
    The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
time by either relaxing the tests in a principled way, or accepting either 
output of two equally valid ones as correct.
    
    (There's also one curious compilation failure in Java 8, related to 
generics. It is fixable by changing to a more explicit declaration that should 
be equivalent. It should be entirely equivalent at compile time, and of course, 
at run time. I am not sure it's not just a javac bug, but, might as well work 
around when it's so easy.)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srowen/mahout MAHOUT-1610

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/mahout/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit 4ac89f32e5b76b73d7d11d05739229de51d189f6
Author: Sean Owen <sro...@gmail.com>
Date:   2014-08-27T14:30:36Z

    Update tests to pass in Java 8

----


> Tests can be made more robust to pass in Java 8
> -----------------------------------------------
>
>                 Key: MAHOUT-1610
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1610
>             Project: Mahout
>          Issue Type: Bug
>          Components: Integration
>    Affects Versions: 0.9
>         Environment: Java 1.8.0_11 OS X 10.9.4
>            Reporter: Sean Owen
>            Assignee: Sean Owen
>            Priority: Minor
>              Labels: java8, tests
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on 
> Java 8). The failures are benign, and just due to tests looking for 
> too-specific values or expecting things like a certain ordering of hashmaps. 
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same 
> time by either relaxing the tests in a principled way, or accepting either 
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics. 
> It is fixable by changing to a more explicit declaration that should be 
> equivalent. It should be entirely equivalent at compile time, and of course, 
> at run time. I am not sure it's not just a javac bug, but, might as well work 
> around when it's so easy.)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to