[
https://issues.apache.org/jira/browse/MAHOUT-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113907#comment-14113907
]
ASF GitHub Bot commented on MAHOUT-1610:
----------------------------------------
Github user dlyubimov commented on the pull request:
https://github.com/apache/mahout/pull/46#issuecomment-53745490
> may still have the commit bit for ASF git, but can't merge the pull
request myself
Thanks, Sean.
Yes, you can merge. A bit exploded beyond what's needed IMO but still
useful [1]. Also, it works best if master is first merged to the PR branch and
conflicts, if any, resolved there, so when you `--squash` stuff to master, you
don't have to worry about conflicts on top of everything else. Hope this helps.
[1] http://mahout.apache.org/developers/github.html
> Tests can be made more robust to pass in Java 8
> -----------------------------------------------
>
> Key: MAHOUT-1610
> URL: https://issues.apache.org/jira/browse/MAHOUT-1610
> Project: Mahout
> Issue Type: Bug
> Components: Integration
> Affects Versions: 0.9
> Environment: Java 1.8.0_11 OS X 10.9.4
> Reporter: Sean Owen
> Assignee: Sean Owen
> Priority: Minor
> Labels: java8, tests
>
> Right now, several tests don't seem to pass when run with Java 8 (at least on
> Java 8). The failures are benign, and just due to tests looking for
> too-specific values or expecting things like a certain ordering of hashmaps.
> The tests can easily be made to pass both Java 8 and Java 6/7 at the same
> time by either relaxing the tests in a principled way, or accepting either
> output of two equally valid ones as correct.
> (There's also one curious compilation failure in Java 8, related to generics.
> It is fixable by changing to a more explicit declaration that should be
> equivalent. It should be entirely equivalent at compile time, and of course,
> at run time. I am not sure it's not just a javac bug, but, might as well work
> around when it's so easy.)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
