Including PRs that may happen on private company github branches to private
code once public master is merged to them. Such is unfortunate workings of
github. So please don't.


On Thu, Aug 28, 2014 at 9:52 AM, Dmitriy Lyubimov <[email protected]> wrote:

>
>
>
> On Thu, Aug 28, 2014 at 9:48 AM, Ted Dunning <[email protected]>
> wrote:
>
>>
>> If you do the commit with the github note "closes #xx", then github does
>> the right thing.  Your commit does the merge.
>>
>
> This is a bad advice.  Please always use github repo specified. it needs
> to say "closes apache/mahout #xx" since just "closes #xx" also closess ALL
> PRs in all collaborator's branches that just happen to have the same
> ordinal number. as experienced first hand.
>
>

Reply via email to