[ 
https://issues.apache.org/jira/browse/CONNECTORS-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540263#comment-13540263
 ] 

Karl Wright commented on CONNECTORS-594:
----------------------------------------

Ok, I had a first glance at the code itself.

There are a number of problems in the code itself, notably exception handling 
and dealing properly with session setup vs. connection.  These, however, are 
minor enough that I could correct them myself over time.  The biggest problem 
is the potentially incompatible jar dependencies.

However, am I correct that basically all you have done is adapt the Solr 
connector to use the Solr-j library, and add additional parameters and 
dependencies as required by that library?  If that is true, then we need to 
decide what the right approach should be in dealing with all variants of Solr. 
The possible approaches are:

- Have a separate connector for Solr 3 and Solr 4 and SolrCloud, as is the case 
now
- Have one connector that allows you to select which Solr variant to use

The second approach is arguably better for a number of reasons.  Specifically, 
each variant could class-load its own version of Solr-j, and the required 
dependencies.

I'll look into this possibility in more detail and post what I find.

                
> SolrCloud Output Connector
> --------------------------
>
>                 Key: CONNECTORS-594
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-594
>             Project: ManifoldCF
>          Issue Type: New Feature
>    Affects Versions: ManifoldCF 1.0.1
>            Reporter: Minoru Osuka
>            Priority: Minor
>             Fix For: ManifoldCF next
>
>         Attachments: solrcloud-output-connector.tar.gz
>
>
> The Output Connectors doesn't support SolrCloud currently.
> Since the Solr 4.0 released, I think there is a need for support for 
> SolrCloud.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to