Hi Andy, thanks for doing a quick check. I'll try answering to all comments:
1. Release Artifacts ============== The archives that I published on people.apache.org are those that will be included in the release (i.e. src, installer, webapp, ldpath). The maven artifacts are in the Apache Snapshot repository: https://repository.apache.org/content/repositories/snapshots/org/apache/marmotta/ 2. LICENSE and NOTICE =================== I updated the LICENSE.txt file of the source distribution according to your comment. I apparently forgot adding the additional copyrights there that I added to the individual modules (see e.g. the LICENSE file in platform/marmotta-core/src/main/resources/META-INF). You can check the updated license file here: https://git-wip-us.apache.org/repos/asf?p=incubator-marmotta.git;a=blob;f=LICENSE.txt;h=3641b8ee0b97c06cefb918566ffa90fd24d27457;hb=HEAD The reason why there are directories with similar layout but differing NOTICE and COPYING is that you actually asked us to provide customised versions of these files for all distribution packages that should be included in the release. According to the guidelines of the ASF [1], the NOTICE and COPYING files should only mention the issues that are really relevant for the distribution package, there will be small differences (e.g. the installer distribution bundles the webapp plus some more libraries used for setting up and configuring). For the COPYING and NOTICE files I also tried to take into account the different licensing conditions between permissive and reciprocal licenses. Unfortunately I am not a lawyer, so it might easily be I did something wrong here. [1] http://www.apache.org/dev/licensing-howto.html 3. Failing Build =========== We are building the whole project using a clean local repository from time to time, so I am fairly sure that it builds cleanly. However, since the project has many modules that depend on each other, and due to the fact that Maven works the way it works, it is necessary that you do the build using mvn clean install You can run a complete build with a clean local repository as follows: mvn clean install -Dmaven.repo.local=/tmp/testrepo Running only "mvn test" will not install the modules in your local repository, so the dependencies between modules cannot be satisfied. The most likely reason why the test fails is that you don't have internet access, as it tests a webservice wrapper. We have two options here: either mocking the reply and then not being able to test the whole thing or accepting that the service might not be available. Maybe we can add a check for network availability in this specific test (like we do for DBPedia). 4. Debug Output for Tests =================== We like it that way, because it allows you to debug why a test fails :) If there are more people who complain, it should be fairly easy to add a simple logback configuration to all modules that can be configured at command line to include/exclude debug statements. 2013/3/14 Andy Seaborne <[email protected]> > On 14/03/13 11:34, Sebastian Schaffert wrote: > >> Hi Fabian and Andy, >> >> I am now uploading the release artifacts to: >> >> http://people.apache.org/~**sschaffert/3.0.0-incubating-**SNAPSHOT/<http://people.apache.org/~sschaffert/3.0.0-incubating-SNAPSHOT/> >> >> If you find some time, it would be great if you can have a look whether we >> did everything properly. I tried taking into account the suggestions made >> by Andy regarding the LICENSE and NOTICE files. >> >> If everything is ok, I'd like to prepare the release this afternoon on >> dist.apache.org and start a vote (on this list and on the incubator >> list). >> :-) >> > > This is the first release and everything is new. This needs proper > checking first. This is also a time to start to focus outward to the > community to be formed around the codebase. > > It will take some time to do the checking. We are volunteers; Nandana is > travelling ATM. I'm out of time today. > > What exactly is being released? > Where are the maven artifacts? > > I just downloaded the src file and found it contains two directories with > similar stuff in it. > > The two NOTICE files are different. > > LICENCE does not include anything but the AL - there is other source code > included so that does not look right to me. > > > mvn test -> fails the build > > [INFO] LDClient Provider: PHPBB Resource Access .......... SUCCESS [0.227s] > [INFO] LDClient Provider: Facebook Graph ................. FAILURE [1.803s] > [INFO] LDClient: Reactor ..............................**... SKIPPED > > (there being no instructions, I guessed) > > and I'm fairly sure it only got that far because I'd already run maven a > few times already. Earlier, it had problems on "Apache Marmotta Installer" > due to unresolved artifacts. > > DEBUG is on ... bit verbose. > > Andy > > > >> Greetings, >> >> Sebastian >> >> >> 2013/3/14 Fabian Christ <[email protected]> >> >> 2013/3/14 Sebastian Schaffert <[email protected]>: >>> >>>> the overhead is that everything will be under version control in this >>>> repository, wasting space with large binary files that are probably not >>>> >>> yet >>> >>>> sufficiently prepared for release >>>> >>> >>> But don't you think that Infra has thought about this when setting up >>> the dev repo? I would not care. It is there - so use it ;) >>> >>> Anyway - I really have no problem if you prefer to use p.a.o. for this >>> step now. >>> >> > > > >>> >>> -- >>> Fabian >>> http://twitter.com/fctwitt >>> >>> >> >
