Hi Andy, 2013/3/14 Andy Seaborne <[email protected]>
> On 14/03/13 14:57, Sebastian Schaffert wrote: > >> Hi Andy, >> >> thanks for doing a quick check. I'll try answering to all comments: >> >> 1. Release Artifacts >> ============== >> >> The archives that I published on people.apache.org are those that will be >> included in the release (i.e. src, installer, webapp, ldpath). The maven >> artifacts are in the Apache Snapshot repository: >> >> https://repository.apache.org/**content/repositories/** >> snapshots/org/apache/marmotta/<https://repository.apache.org/content/repositories/snapshots/org/apache/marmotta/> >> > > I see all sorts of dates like 08 March so they will not reflect the fixes > to L&N in META-INF. > If you scroll down, you will see the more recent snapshots from this afternoon, which also reflect the fixes to LICENSE and NOTICE. Unfortunately, the Apache Snapshot Nexus only removes old snapshots from time to time, so the topmost entries will be the oldest snapshots. Additionally, artifacts that have not been changed are apparently not even uploaded, so for some modules you will indeed find only old libraries. Which is because they are not affected by the L&N fixes (e.g. all the kiwi modules are written only by me and do not include any external source code). An example for a module that has been fixed is: https://repository.apache.org/content/repositories/snapshots/org/apache/marmotta/sesame-tools-rio-jsonld/3.0.0-incubating-SNAPSHOT/ Please scroll down to -14 to find the most recent snapshot. > > Are all artifacts going into nexus /releases/ for this release? Yes, all artifacts will be going into nexus which are also in the snapshot releases. > > > 2. LICENSE and NOTICE >> =================== >> >> I updated the LICENSE.txt file of the source distribution according to >> your >> comment. I apparently forgot adding the additional copyrights there that I >> added to the individual modules (see e.g. the LICENSE file in >> platform/marmotta-core/src/**main/resources/META-INF). >> >> You can check the updated license file here: >> >> https://git-wip-us.apache.org/**repos/asf?p=incubator-** >> marmotta.git;a=blob;f=LICENSE.**txt;h=**3641b8ee0b97c06cefb918566ffa90** >> fd24d27457;hb=HEAD<https://git-wip-us.apache.org/repos/asf?p=incubator-marmotta.git;a=blob;f=LICENSE.txt;h=3641b8ee0b97c06cefb918566ffa90fd24d27457;hb=HEAD> >> > > Could you rebuild so we're checking a single thing? Uploading a new version. It is again available at http://people.apache.org/~sschaffert/3.0.0-incubating-SNAPSHOT/ I have also created a Maven deployment directory that exactly contains the artifacts that will be deployed to the Maven repository. This might make checking the artifacts a bit simpler (I admit that we have many of them). :) http://people.apache.org/~sschaffert/repo/ > > > The reason why there are directories with similar layout but differing >> NOTICE and COPYING is that you actually asked us to provide customised >> versions of these files for all distribution packages that should be >> included in the release. >> > > Which is which? Both were quite large. > The following directories currently contain a NOTICE (and COPYING) file: - source distribution: ./NOTICE.txt this is the main NOTICE file for the source distribution and describes the source files from third parties that are included in the source tree. It does not describe the dependencies that will be fetched when running Maven (since the distribution is source). - JAR modules: ./commons/sesame-tools-rio-jsonld/src/main/resources/META-INF/NOTICE ./commons/sesame-tools-rio-rss/src/main/resources/META-INF/NOTICE ./platform/marmotta-core/src/main/resources/META-INF/NOTICE ./platform/marmotta-ldpath/src/main/resources/META-INF/NOTICE ./platform/marmotta-sparql/src/main/resources/META-INF/NOTICE ./launchers/marmotta-splash/src/ext/resources/META-INF/NOTICE these are all the jar modules that contain third-party source code, at least as far as I am aware of. All notices mentioned here should also be mentioned in the ./NOTICE.txt file. In all other cases the default NOTICE and COPYING (fetched at build time using the remote-resources-plugin) applies. - binary modules (launchers) ./launchers/marmotta-installer/src/main/resources/installer/NOTICE.txt ./launchers/marmotta-webapp/src/main/webapp/META-INF/NOTICE ./launchers/marmotta-webapp/NOTICE.txt ./libraries/ldpath/ldpath-backend-linkeddata/NOTICE.txt these are the binary launcher configurations that we aim to distribute (artifacts with classifiers -installer, -webapp, -ldpath in the people.apache.org directory). The NOTICE files contain all notices from the source distribution, and in addition all notices for dependencies that are bundled in these binary distributions. Same for LICENSE. marmotta-installer: is the standalone installer (installation wizard) that users can directly use without any Java experience marmotta-webapp: is the web application (.war file) that users with Java experience can deploy in a Java Application Server marmotta-splash: is the startup screen used by the installer, it bundles some 3rd party GUI classes > > The two directories have different dates - 8th and 14th IIRC (I'm now in a > cafe drinking coffee waiting for a physio appt :-). > > What I'm trying to head off is comments on general@ because if you go > round that loop too many times, people stop looking. > Yes, and we are really grateful for this, even if this is quite boring work for both you and me :) > > The source-release is the buildable tree - as it does not contain the > redistributed files, the necessary N&L will be somewhere in the build > system. The source-release builds the secondary binaries. > > -Papache-release makes source-release the SVN tree at the right moment. In our case it will be -Pmarmotta-release and it will be triggered using the mvn release:release command, but otherwise yes :) > > 3. Failing Build >> =========== >> >> We are building the whole project using a clean local repository from time >> to time, so I am fairly sure that it builds cleanly. However, since the >> project has many modules that depend on each other, and due to the fact >> that Maven works the way it works, it is necessary that you do the build >> using >> >> mvn clean install >> >> You can run a complete build with a clean local repository as follows: >> >> mvn clean install -Dmaven.repo.local=/tmp/**testrepo >> >> Running only "mvn test" will not install the modules in your local >> repository, so the dependencies between modules cannot be satisfied. >> >> The most likely reason why the test fails is that you don't have internet >> access, as it tests a webservice wrapper. >> > > I did :-) else I would not have been able to get the dependencies! > I tried a completely clean build with empty local repository on three different machines now (Mac, Linux, Windows) and it worked on all like a breeze. :-) So maybe it was solar turbulences or something. ;-) BTW, if you were successfully running "mvn clean install", then the tests were already executed successfully also ;-) Greetings and thanks! Sebastian
