> -----Original Message-----
> From: Vincent Massol [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, June 18, 2003 10:33 AM
> To: 'Maven Developers List'
> Subject: RE: Recent changes in war plugin
>
>
>
> > -----Original Message-----
> > From: Michal Maczka [mailto:[EMAIL PROTECTED]
> > Sent: 18 June 2003 10:01
> > To: 'Maven Developers List'
> > Subject: RE: Recent changes in war plugin
> >
> > Yes.
> > I am still working on deployer.
> > That's the art which I want to use in this plugin to add missing
> > functionality.
> >
> > Once I am readay with this for war plugin, I am planning to change
> also
> > other plugins.
> >
> >
> > Last time I am asking:
> >
> > Does anybody has something against building war ___always__ in two
> > distinct
> > steps?
>
> I don't think I like it. At least I would like to keep using the Ant war
> task which does a lot of things your implementation will not be doing
> right away. And we will benefit from any improvement to Ant war task.
>
What's so magical in ant war task?
As I get it it's just simple extension of jar task
which often prints "stupid" warning messages like:
---- Taken from ANT code -----------------
if (deploymentDescriptor == null
|| !fu.fileNameEquals(deploymentDescriptor, file)
|| descriptorAdded) {
log("Warning: selected " + archiveType
+ " files include a WEB-INF/web.xml which will be
ignored "
+ "(please use webxml attribute to "
+ archiveType + " task)", Project.MSG_WARN);
} else
------------------------------------------
Why web.xml should not be kept in src/webapp/WEB-INF?
What's so wrong in it? Why Ant dislikes this?
I don't see any benefits which we gain using this ant target.
And personally I think that as much as possible of the code should be done
in pure java - not in jelly with help of ant. I think that that's the
direction Maven should take.
This will increase quality of the code, speed and code reuse.
So from my point of view less dependencies on ant - better code.
> So I'm -1 to drop usage of the Ant war task.
>
> I'm -0 (maybe even -1) to always build in 2 steps
>
> I'm +1 to add a goal or any other property to support building in 2
> steps. For example:
>
> - Define the following properties in war's plugin.properties file:
>
> maven.war.src.extra = ${maven.build.dir}/war
>
> - Modify plugin.jelly to:
>
> <war warfile="${maven.war.build.dir}/${maven.war.final.name}"
> webxml="${maven.war.webxml}" update="true">
> [...]
> <j:if test="${SrcExtraDirExists == 'true'}">
> <fileset dir="${maven.war.src.extra}"/>
> </j:if>
>
That's some idea...
Michal
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
