On Thu, 2004-01-15 at 23:26, Ben Walding wrote:
> id / groupId works in 1.0-rc1
> groupId / artifactId doesn't
For the reactor to pick them up properly or in general?
> And I know that the ordering of the elements matters. It is very very
> dodgy.
I would say it has be the old way or the new way not a mixture. Either
groupId/artifactId or id.
> Have a look inside the code :)
>
> The law of unexpected consequences runs rife in there.
>
> setId("a:b")
That is something I never intended to be done, but oh well.
> doesn't leave the project in the same state as
> setGroupId("a");setArtifactId("b")
>
> Cheers,
>
> Ben
>
> Brett Porter wrote:
>
> >Que? I use groupId/id all the time and its fine. Looking at the code, the
> >proposed changes should be fine: internally id = artifactId, but getId()
> >returns groupId:artifactId. artifactId has its own get/set.
> >
> >The only problem is that getId() seems to setArtifactId(id) even if id were
> >null it would assign that.
> >
> >Accursed old project code! :)
> >
> >I guess its just worth testing first, but as long as you can output
> >${pom.id} and ${pom.artifactId} in that order and get the correct results,
> >then it should be fine?
> >
> >Cheers,
> >Brett
> >
> >
> >
> >>-----Original Message-----
> >>From: Jason van Zyl [mailto:[EMAIL PROTECTED]
> >>Sent: Friday, 16 January 2004 1:33 AM
> >>To: Maven Developers List
> >>Subject: RE: Plugin cleanup phase 1
> >>
> >>
> >>On Thu, 2004-01-15 at 16:48, Brett Porter wrote:
> >>
> >>
> >>>+0 if and only if <artifactId> works with RC1. From memory, I don't
> >>>+think it
> >>>does.
> >>>
> >>>
> >>Ben, I think we cound that groupId/artifactId are fine but
> >>it's the combination of groupId/id that caused problems, yes?
> >>
> >>
> >>
> >>>- Brett
> >>>
> >>>
> >>>
> >>>>-----Original Message-----
> >>>>From: Jason van Zyl [mailto:[EMAIL PROTECTED]
> >>>>Sent: Thursday, 15 January 2004 6:41 PM
> >>>>To: Maven Developers List
> >>>>Subject: Plugin cleanup phase 1
> >>>>
> >>>>
> >>>>Hi,
> >>>>
> >>>>Does anyone object to flipping all the plugins over to using
> >>>><groupId/>/<artifactId/> instead of just <id/> to promote the
> >>>>the proper way?
> >>>>
> >>>>People just take plugins and copy them and propagate things
> >>>>we don't want.
> >>>>
> >>>>--
> >>>>jvz.
> >>>>
> >>>>Jason van Zyl
> >>>>[EMAIL PROTECTED]
> >>>>http://maven.apache.org
> >>>>
> >>>>First, the taking in of scattered particulars under one Idea,
> >>>>so that everyone understands what is being talked about ...
> >>>>Second, the separation of the Idea into parts, by dividing it
> >>>>at the joints,
> >>>>as nature directs, not breaking any limb in half as a bad
> >>>>carver might.
> >>>>
> >>>>-- Plato, Phaedrus (Notes on the Synthesis of Form by C.
> >>>>
> >>>>
> >>Alexander)
> >>
> >>
> >>>>
> >>>>
> >>>>
> >>--------------------------------------------------------------------
> >>
> >>
> >>>>-
> >>>>To unsubscribe, e-mail: [EMAIL PROTECTED]
> >>>>For additional commands, e-mail: [EMAIL PROTECTED]
> >>>>
> >>>>
> >>>>
> >>--
> >>jvz.
> >>
> >>Jason van Zyl
> >>[EMAIL PROTECTED]
> >>http://maven.apache.org
> >>
> >>believe nothing, no matter where you read it,
> >>or who has said it,
> >>not even if i have said it,
> >>unless it agrees with your own reason
> >>and your own common sense.
> >>
> >>-- Buddha
> >>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: [EMAIL PROTECTED]
> >>For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >>
> >>
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
--
jvz.
Jason van Zyl
[EMAIL PROTECTED]
http://maven.apache.org
happiness is like a butterfly: the more you chase it, the more it will
elude you, but if you turn your attention to other things, it will come
and sit softly on your shoulder ...
-- Thoreau
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
