Well, ok, here it is:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=562896a192072b9044a6b2fd37ff31bf638214c8

For Windows 9x/ME, only the first line of jvm.config can be used.

I also started checking if I could boil down mvnDebug.bat to pretty much
just delegate to mvn.bat, but Windows 9x compatibility and this "4NT Shell
from jp software" which I never heard of before changed my mind - I'm not
that deep into this to make sure I don't break something for non-WinNT
users. So I left it as it is and made sure mvn.bat and mvnDebug.bat are
properly synchronized.

One thing we could do to make stuff easier around these .bat scripts is to
drop support for this 4NT shell and Windows versions that are not based on
NT (i.e. Windows 9x / ME).



2015-02-25 19:38 GMT+01:00 Jason van Zyl <ja...@takari.io>:

> Awesome, thanks!
>
> On Feb 25, 2015, at 10:32 AM, Andreas Gudian <andreas.gud...@gmail.com>
> wrote:
>
> > Hi guys,
> >
> > I'm stuck with a windows box and I can give it a try...
> >
> > .bat-scripting is not really a joy, but what's in the patch should be
> > translatable.
> >
> > Andreas
> >
> > 2015-02-25 17:01 GMT+01:00 Igor Fedorenko <i...@ifedorenko.com>:
> >
> >> You can see actual diff to mvn shell script in [1], but the changes was
> >> basically two-fold. First, find nearest parent directory that contains
> >> .mvn/ subdirectory. This parent is considered "true" multi-module
> >> project root (MNG-1958). Second, if .mvn/java.config file is present
> >> immediately under the true multimodule project root, use its content as
> >> java invocation parameters, i.e. similar to $MAVEN_OPTS environment
> >> variable.
> >>
> >> I don't know enough about Windows scripting to make similar change to
> >> mvn.bat and mvnDebug.bat batch files.
> >>
> >> [1] https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> >> 8ed9a1caa8890773b45c6c408a4e40acf4f4b0fd
> >>
> >> --
> >> Regards,
> >> Igor
> >>
> >>
> >> On 2015-02-25 9:56, Robert Patrick wrote:
> >>
> >>> What exactly is the problem that Igor ran into that limits his solution
> >>> to Unix-only?  Knowing this would help people determine what the level
> of
> >>> effort needed to solve the problem.
> >>>
> >>>
> >>> --
> >>> Robert Patrick <robert.patr...@oracle.com>
> >>> VP, Oracle Corporation
> >>> 7460 Warren Pkwy, Ste. 300      Office: +1.972.963.2872
> >>> Frisco, TX 75034, USA           Mobile: +1.469.556.9450
> >>>
> >>> Professional Oracle WebLogic Server
> >>> by Robert Patrick, Gregory Nyberg, and Philip Aston
> >>> with Josh Bregman and Paul Done
> >>> Book Home Page: http://www.wrox.com/
> >>> Kindle Version: http://www.amazon.com/
> >>>
> >>>
> >>> -----Original Message-----
> >>> From: Jason van Zyl [mailto:ja...@takari.io]
> >>> Sent: Wednesday, February 25, 2015 7:40 AM
> >>> To: Maven Developers List
> >>> Subject: Re: Maven 3.2.6
> >>>
> >>>
> >>> On Feb 24, 2015, at 11:31 PM, Arnaud Héritier <aherit...@gmail.com>
> >>> wrote:
> >>>
> >>> I had a quick look at the changeling and I'm +1 for a 3.3.0 with
> >>>> improvements like the toolchain integration and few others I'm far
> >>>> from the project and won't veto anything as I have no time for it but
> >>>> I don't understand why http://jira.codehaus.org/browse/MNG-5767 was
> >>>> integrated without a windows support ? For me it is everything or
> >>>> nothing.
> >>>> Noone could help Igor on this ?
> >>>>
> >>>
> >>> It would be great if someone would help, but it is still a step
> forward.
> >>> For projects that require this and document specific requirements it
> will
> >>> just work for non-Windows users. Say the project needs 8gb to run
> >>> correctly: in most cases no one reads the documentation they run the
> build
> >>> and it fails. Then they go read something and figure it out and it
> works.
> >>> We've at least made it work for some people. If there isn't a single
> Maven
> >>> committer who uses Windows who can add the same capabilities or we
> can't
> >>> find a contributor I don't think it should stop the feature for going
> in
> >>> for the people it can benefit.
> >>>
> >>> Igor and I don't use Windows regularly, don't know Windows, don't want
> to
> >>> know Windows and none of our customers use Windows.
> >>>
> >>> It's overall a net improvement. For me it's a about gradual
> improvement.
> >>> But I've asked on Twitter if there are any Windows users that can help.
> >>>
> >>> Many months/years ago the integration of colors in logs output was
> >>>> rejected in a part because we wasn't confident in the windows support
> ...
> >>>>
> >>>
> >>> I don't think that was the issue. The issue was us not being able the
> >>> decide on an underlying logging framework. I've seen JANSI working
> fine on
> >>> Windows for years.
> >>>
> >>>
> >>>> My 2 cents.
> >>>>
> >>>> On Wed, Feb 25, 2015 at 1:29 AM, Mark Derricutt <m...@talios.com>
> wrote:
> >>>>
> >>>> On 25 Feb 2015, at 4:06, Karl Heinz Marbaise wrote:
> >>>>>
> >>>>> based on the list of changes i would suggest to make a 3.3.0 instead
> >>>>>> of
> >>>>>>
> >>>>> 3.2.6....to make clear something is introduced....
> >>>>>
> >>>>> +1 on 3.3.0 here. Bring on the changes!
> >>>>>
> >>>>> Mark
> >>>>>
> >>>>> --
> >>>>> Mark Derricutt
> >>>>> http://www.theoryinpractice.net
> >>>>> http://www.chaliceofblood.net
> >>>>> http://plus.google.com/+MarkDerricutt
> >>>>> http://twitter.com/talios
> >>>>> http://facebook.com/mderricutt
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>> -----
> >>>> Arnaud Héritier
> >>>> http://aheritier.net
> >>>> Mail/GTalk: aheritier AT gmail DOT com Twitter/Skype : aheritier
> >>>>
> >>>
> >>> Thanks,
> >>>
> >>> Jason
> >>>
> >>> ----------------------------------------------------------
> >>> Jason van Zyl
> >>> Founder, Takari and Apache Maven
> >>> http://twitter.com/jvanzyl
> >>> http://twitter.com/takari_io
> >>> ---------------------------------------------------------
> >>>
> >>> People develop abstractions by generalizing from concrete examples.
> >>> Every attempt to determine the correct abstraction on paper without
> >>> actually developing a running system is doomed to failure. No one is
> that
> >>> smart. A framework is a resuable design, so you develop it by looking
> at
> >>> the things it is supposed to be a design of. The more examples you
> look at,
> >>> the more general your framework will be.
> >>>
> >>>   -- Ralph Johnson & Don Roberts, Patterns for Evolving Frameworks
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For
> additional
> >>> commands, e-mail: dev-h...@maven.apache.org
> >>>
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> >>> For additional commands, e-mail: dev-h...@maven.apache.org
> >>>
> >>>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> >> For additional commands, e-mail: dev-h...@maven.apache.org
> >>
> >>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder, Takari and Apache Maven
> http://twitter.com/jvanzyl
> http://twitter.com/takari_io
> ---------------------------------------------------------
>
> Lastly, "Impossible." The lamest of the lame excuses! Difficult maybe, or
> impractical, or too expensive, but rarely is anything impossible.
>
>   -- Yvon Chouinard, Let my People Go Surfing
>
>
>
>
>
>
>
>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Reply via email to