fixed thanks for the feedback Regards,
Hervé Le dimanche 17 juillet 2016 11:19:44 Michael Osipov a écrit : > Am 2016-07-17 um 09:49 schrieb Hervé BOUTEMY: > > I worked on documentation to finish from my pov my work on this API: > > http://maven.apache.org/shared-archives/maven-shared-utils-LATEST/ > > > > I'd like to release maven-shared-utils 3.1.0 to start releasing plugins > > with styled messages, and of course work on releasing Maven > > 3.4.0-SNAPSHOT > > > > any objection? > > any improvement? > > There are some issues need to be addressed: > > 1. MessageUtils: > 1.1 "to manage colors colors consistently across": duplicate word > 1.2 isColor(): What is that supposed to mean? Is color what? It should > say isColorEnabled() or isColorSupportEnabled(). It's just to short and > meaningless. Plurals in docs, we have several colors. > 1.3 setColor(): Same issue. What color can I set? A boolean color? > setColorSupport() or similar, complying with the 1.2. "Activates message > color": Activates message colors > 1.4 stripAnsi(): Same issue. stripAnsiColors(). > 1.5 systemUninstall(): no docs. > 2. Style: > 2.1 toString: Why not initialize the StringBuilder with name() + '=' > when you are prepending it anyway? > > Michael > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
